-
Couldn't load subscription status.
- Fork 3
infra: add cleanup script for vespa & embedded files #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikochiko
wants to merge
6
commits into
master
Choose a base branch
from
vespa-cleanup-script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
88aed75
refactor: fix return type of 'vespa_search_results_to_refs'
nikochiko 89e1e88
infra: add cleanup script for vespa & embedding documents
nikochiko 6e5538d
fix: VespaResponse.is_successful() usage
nikochiko cb52efb
fix: avoid double evaluation of embeddings queryset
nikochiko bf89591
fix: skip always true if generator check
nikochiko ff9c772
fix: make linter happy
nikochiko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import typing | ||
| from datetime import timedelta | ||
|
|
||
| from django.utils import timezone | ||
|
|
||
| from daras_ai_v2 import settings | ||
| from daras_ai_v2.vector_search import get_vespa_app | ||
| from embeddings.models import EmbeddedFile | ||
|
|
||
| if typing.TYPE_CHECKING: | ||
| from vespa.io import VespaResponse | ||
|
|
||
|
|
||
| STALENESS_THRESHOLD_DAYS = 90 | ||
| BATCH_SIZE = 1_000 | ||
|
|
||
|
|
||
| def cleanup_stale_cache(): | ||
| vespa = get_vespa_app() | ||
|
|
||
| while True: | ||
| stale_files = EmbeddedFile.objects.prefetch_related( | ||
| "embeddings_references" | ||
| ).filter( | ||
| updated_at__lt=timezone.now() - timedelta(days=STALENESS_THRESHOLD_DAYS) | ||
| )[:BATCH_SIZE] | ||
| if not stale_files: | ||
| break | ||
|
|
||
| docs_to_delete = ( | ||
| {"id": ref.vespa_doc_id} | ||
| for ef in stale_files | ||
| for ref in ef.embeddings_references.all() | ||
| ) | ||
| if docs_to_delete: | ||
| total_deleted = 0 | ||
nikochiko marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| def vespa_callback(response: "VespaResponse", id: str): | ||
| nonlocal total_deleted | ||
| if response.is_successful: | ||
| total_deleted += 1 | ||
| else: | ||
| print( | ||
| f"Failed to delete document {id} from Vespa: {response.status_code} - {response.get_json()}" | ||
| ) | ||
|
|
||
nikochiko marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| vespa.feed_iterable( | ||
| docs_to_delete, | ||
| schema=settings.VESPA_SCHEMA, | ||
| operation_type="delete", | ||
| callback=vespa_callback, | ||
| ) | ||
| print(f"Deleted {total_deleted} documents from Vespa.") | ||
|
|
||
| deleted_per_model = EmbeddedFile.objects.filter( | ||
| id__in=[ef.id for ef in stale_files] | ||
| ).delete() | ||
| print(f"Deleted EmbeddedFiles & related objects: {deleted_per_model}") | ||
|
|
||
|
|
||
| def run(): | ||
| cleanup_stale_cache() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.