Update to imara-diff 0.2 in diff slider test
#2288
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
reviewed
Dec 9, 2025
| use gix_diff::blob::intern::TokenSource; | ||
| use gix_diff::blob::unified_diff::ContextSize; | ||
| use gix_diff::blob::{Algorithm, UnifiedDiff}; | ||
| use gix_diff::blob::v2::{Algorithm, BasicLineDiffPrinter, Diff, InternedInput, UnifiedDiffConfig}; |
Member
There was a problem hiding this comment.
It's interesting that v2 is available at all as it shouldn't be available by default.
Let me fix that
Member
There was a problem hiding this comment.
Hmm, seems like this code should not compile, it's fine on main.
Member
There was a problem hiding this comment.
Sorry about that, I didn't realise that this is a test in gix-diff-tests, which enables the feature. It was a long day yesterday 😅.
Contributor
Author
There was a problem hiding this comment.
No worries, I also could have provided that context. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to #2287. It updates the diff slider test to use
imara-diff0.2. In my non-representative sample of ~3000 diffs fromgitoxide, it matches the git baseline in ~95 % of cases.