Skip to content

Reenable git-daemon journey tests on CI by disabling artifact caching #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Reenable git-daemon journey tests on CI by disabling artifact caching #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65788e8
Revert "forcefully fix CI until it's clear what the problem is"
EliahKagan Dec 16, 2024
bf2abdb
Try not caching journey test dependencies
EliahKagan Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- uses: extractions/setup-just@v2
- name: Run journey tests
run: just ci-journey-tests
Expand Down
4 changes: 2 additions & 2 deletions tests/journey/gix.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ title "gix (with repository)"

# for some reason, on CI the daemon always shuts down before we can connect,
# or isn't actually ready despite having accepted the first connection already.
(not_on_ci with "git:// protocol"
(with "git:// protocol"
launch-git-daemon
(with "version 1"
it "generates the correct output" && {
Expand Down Expand Up @@ -278,7 +278,7 @@ title "gix commit-graph"
)
)
fi
(not_on_ci with "git:// protocol"
(with "git:// protocol"
launch-git-daemon
(with "version 1"
(with "NO output directory"
Expand Down
Loading