Skip to content

Run job installation in workflow release #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

NobodyXu
Copy link
Contributor

Fixed #1553

also rm rust-cache from job installation as it is not effective for cargo-install

Also remove rust-cache as it isn't effective against cargo-install
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help!

Does it mean that installation can fail without failing any of the builds?
If so, it can be merged, but if not, it's probably better to put it into its own workflow file.

@NobodyXu
Copy link
Contributor Author

Does it mean that installation can fail without failing any of the builds?

Yes as long as it's not in github branch protection.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's try it then. It's not mentioned in GitHub branch protections.

@Byron Byron enabled auto-merge August 25, 2024 08:32
@Byron Byron merged commit ce75963 into GitoxideLabs:main Aug 25, 2024
15 checks passed
@NobodyXu NobodyXu deleted the ci/installation branch August 25, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants