Skip to content

Have all nodes within a text-cells adhere to alignments #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

viktorrenkema
Copy link
Contributor

Fixes issue raised by aimlapi.com, text cells can receive additional markup including captions. We weren't accounting for those with the alignments, so now we are.

~closes https://linear.app/gitbook-x/issue/RND-6658/annotations-in-table-cells-with-multi-line-text-makes-it-center

Before
CleanShot 2025-04-22 at 10 12 56@2x

After
CleanShot 2025-04-22 at 10 13 06@2x

Copy link

linear bot commented Apr 22, 2025

Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: 41c811e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 2 changed Apr 24, 2025, 9:25 AM
customers-v2 (Inspect) 👍 Changes approved 2 changed Apr 24, 2025, 9:27 AM
default (Inspect) 👍 Changes approved 45 changed Apr 24, 2025, 9:28 AM
v2-vercel (Inspect) 👍 Changes approved 41 changed Apr 24, 2025, 9:29 AM

@viktorrenkema viktorrenkema force-pushed the viktor/fix-horiz-alignment-on-annotated-table-cells branch from bb8b4aa to 11230ca Compare April 22, 2025 12:02
@viktorrenkema viktorrenkema force-pushed the viktor/fix-horiz-alignment-on-annotated-table-cells branch from 11230ca to 228fcf3 Compare April 22, 2025 12:05
@viktorrenkema viktorrenkema force-pushed the viktor/fix-horiz-alignment-on-annotated-table-cells branch from 2ef7476 to a74b036 Compare April 22, 2025 12:15
@viktorrenkema viktorrenkema force-pushed the viktor/fix-horiz-alignment-on-annotated-table-cells branch from a74b036 to 62313e2 Compare April 22, 2025 12:39
@viktorrenkema viktorrenkema force-pushed the viktor/fix-horiz-alignment-on-annotated-table-cells branch from 70182fa to 41c811e Compare April 24, 2025 09:18
@viktorrenkema viktorrenkema merged commit 0353a81 into main Apr 24, 2025
20 checks passed
@viktorrenkema viktorrenkema deleted the viktor/fix-horiz-alignment-on-annotated-table-cells branch April 24, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants