Use more extensive strict checking for the available alignment options

Author: viktorrenkema

packages/gitbook/src/components/DocumentView/Table/RecordColumnValue.tsx

@@ -115,7 +115,6 @@ export async function RecordColumnValue<Tag extends React.ElementType = 'div'>(
                 return <Tag className={tcls(['w-full', verticalAlignment])}>{''}</Tag>;
             }
 
-            const alignment = getColumnAlignment(definition);
 
             return (
                 <Blocks
@@ -130,9 +129,7 @@ export async function RecordColumnValue<Tag extends React.ElementType = 'div'>(
                         'lg:space-y-3',
                         'leading-normal',
                         verticalAlignment,
-                        alignment === 'right' ? '[&_*]:text-right' : null,
-                        alignment === 'center' ? '[&_*]:text-center' : null,
-                        alignment === 'left' ? '[&_*]:text-left' : null,
+                        getColumnAlignment(definition)
                     ]}
                     context={context}
                     blockStyle={['w-full', 'max-w-[unset]']}
@@ -326,4 +323,4 @@ export async function RecordColumnValue<Tag extends React.ElementType = 'div'>(
         default:
             assertNever(definition);
     }
-}
+}

packages/gitbook/src/components/DocumentView/Table/ViewGrid.tsx

@@ -42,16 +42,13 @@ export function ViewGrid(props: TableViewProps<DocumentTableViewGrid>) {
                         )}
                     >
                         <div role="row" className={tcls('flex', 'w-full')}>
-                            {view.columns.map((column) => {
-                                const alignment = getColumnAlignment(block.data.definition[column]);
-                                return (
-                                    <div
-                                        key={column}
-                                        role="columnheader"
-                                        className={tcls(
+                            {view.columns.map((column) => (
+                                <div
+                                    key={column}
+                                    role="columnheader"
+                                    className={tcls(
                                             styles.columnHeader,
-                                            alignment === 'right' ? 'text-right' : null,
-                                            alignment === 'center' ? 'text-center' : null
+                                            getColumnAlignment(block.data.definition[column])
                                         )}
                                         style={{
                                             width: getColumnWidth({
@@ -63,11 +60,10 @@ export function ViewGrid(props: TableViewProps<DocumentTableViewGrid>) {
                                             minWidth: columnWidths?.[column] || '100px',
                                         }}
                                         title={block.data.definition[column].title}
-                                    >
+                                        >
                                         {block.data.definition[column].title}
-                                    </div>
-                                );
-                            })}
+                                </div>
+                            ))}
                         </div>
                     </div>
                 )}

packages/gitbook/src/components/DocumentView/Table/utils.ts

@@ -1,4 +1,5 @@
 import type { ContentRef, DocumentTableDefinition, DocumentTableRecord } from '@gitbook/api';
+import assertNever from 'assert-never';
 
 /**
  * Get the value for a column in a record.
@@ -14,13 +15,30 @@ export function getRecordValue<T extends number | string | boolean | string[] |
 /**
  * Get the text alignment for a column.
  */
-export function getColumnAlignment(column: DocumentTableDefinition): 'left' | 'right' | 'center' {
+export function getColumnAlignment(column: DocumentTableDefinition) {
+    
+    const defaultAlignment = '[&_*]:text-left';
+
     if (column.type === 'text') {
-        return column.textAlignment ?? 'left';
+            switch (column.textAlignment) {
+                case undefined:
+                case 'left':
+                    return defaultAlignment;
+                    case 'center':
+                        return '[&_*]:text-center';
+                case 'right':
+                    return '[&_*]:text-right';
+                default:
+                    assertNever(column.textAlignment);
+            }
     }
-    return 'left';
+
+    return defaultAlignment;
 }
 
+
+
+
 /**
  * Get the vertical alignment for a column.
  */