Fix Travis build #876
Merged
Fix Travis build #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enumerating manifest resource names with Linq, Mono throws `InvalidProgramExceptions`. See https://travis-ci.org/asbjornu/GitVersion/builds/132266378#L7579 for details on the failure. Doing a simple `foreach` and `yield return` seems to solve the problem.
|
I think it would be wise to merge this and rebase all other pull requests so they are successfully tested on Travis as well (which they aren't now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things to fix the build on Travis so it fails when a unit test fails and also fixes a few issues regarding Unix path handling that were uncovered once the build started failing.