Format no format #4657

9swampy · 2025-08-13T23:02:50Z

Fix legacy .NET composite format syntax

Description

Fixes legacy .NET format syntax {CommitsSinceVersionSource:0000;;''} that was outputting literal text instead of formatted values.

Added LegacyCompositeFormatter for semicolon-separated format sections
Updated ValueFormatter and RegexPatterns to support semicolons
Maintains compatibility with existing ?? syntax

Before: 6.13.54-gv6-CommitsSinceVersionSource-0000-----
After: 6.13.54-gv60002

Related Issue

Fixes #4654

Motivation and Context

Legacy .NET semicolon format syntax stopped working, breaking existing GitVersion configurations.

How Has This Been Tested?

Added comprehensive test suites:

BackwardCompatibilityTests.cs - 8 tests covering legacy format scenarios
Issue4654Tests.cs - 4 tests for the specific issue

All 12 new tests pass. No regression in existing tests.

Screenshots (if appropriate):

N/A

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

9swampy · 2025-08-13T23:06:36Z

@phatcher #4654

9swampy · 2025-08-13T23:46:04Z

src/GitVersion.Core/Core/RegexPatterns.cs

@@ -93,7 +93,7 @@ internal static partial class Common
                    |                                                   # OR
                    (?<member>[A-Za-z_][A-Za-z0-9_]*)                   # member/property name
                    (?:                                                 # Optional format specifier
-                        :(?<format>[A-Za-z0-9\.\-,]+)                   # Colon followed by format string (no spaces, ?, or }), format cannot contain colon
+                        :(?<format>[A-Za-z0-9\.\-,;'"]+)                # Colon followed by format string (including semicolons and quotes)


sonarqubecloud · 2025-08-14T02:48:01Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

9swampy · 2025-08-14T03:04:40Z

Apologies. Two passes is already more time than I had. The first pass was comfortable, the second's expanded in to assumptions that likely warrant a review & retrospect on regression pack coverage? Rollback & regroup the wise call?

asbjornu

Fantastic work! 🎉 Thank you so much for jumping on this so quickly, @9swampy! ❤️

asbjornu · 2025-08-14T12:00:31Z

docs/input/docs/reference/custom-formatting.md

+# Three-section format: positive;negative;zero
+assembly-informational-format: "{Value:positive;negative;zero}"
+
+# Two-section format: positive;negative
+assembly-informational-format: "{Value:pos;neg}"


Could these last two examples be modified to be more practical and real-world relevant, with a line showing the result, as in the first code example?

asbjornu · 2025-08-14T12:01:26Z

docs/input/docs/reference/custom-formatting.md

+- **Third section**: Used for zero values (optional)
+- **Empty quotes** (`''` or `""`) create empty output
+
+**Mixed Syntax:** You can combine legacy semicolon syntax with modern `??` fallback syntax in the same template.


How would ;; and ?? be combined? Can we give a code example for this as well?

asbjornu · 2025-08-14T12:01:59Z

src/GitVersion.Core.Tests/Formatting/BackwardCompatibilityTests.cs

I love the added tests! 🤩 Could we please have a test for the combination of ;; and ?? as well?

asbjornu · 2025-08-14T12:02:22Z

src/GitVersion.Core.Tests/Formatting/DateFormatterTests.cs

@@ -1,7 +1,7 @@
 using System.Globalization;
 using GitVersion.Formatting;

-namespace GitVersion.Tests.Formatting;
+namespace GitVersion.Core.Tests.Formatting;


GitVersion.Core should not be a namespace. :)

Suggested change

namespace GitVersion.Core.Tests.Formatting;

namespace GitVersion.Tests.Formatting;

asbjornu · 2025-08-14T12:04:24Z

src/GitVersion.Core.Tests/Formatting/LegacyFormatterProblemTests.cs

+
+        // Currently this will throw or behave unexpectedly
+        // Should either throw meaningful error or handle gracefully
+        Assert.Throws<ArgumentException>(() => template.FormatWith(semanticVersion, environment));


I think it's a good practice to test the returned ArgumentException to ensure that the right guard clause is throwing it. This just ensures that an ArgumentException is being thrown anywhere by the code path, not necessarily by our own code.

asbjornu · 2025-08-14T12:06:03Z

src/GitVersion.Core.Tests/Formatting/StringFormatterTests.cs

@@ -1,6 +1,6 @@
 using GitVersion.Formatting;

-namespace GitVersion.Tests.Formatting;
+namespace GitVersion.Core.Tests.Formatting;


Suggested change

namespace GitVersion.Core.Tests.Formatting;

namespace GitVersion.Tests.Formatting;

asbjornu · 2025-08-14T12:06:09Z

src/GitVersion.Core.Tests/Formatting/ValueFormatterTests.cs

@@ -1,7 +1,7 @@
 using System.Globalization;
 using GitVersion.Formatting;

-namespace GitVersion.Tests.Formatting;
+namespace GitVersion.Core.Tests.Formatting;


Suggested change

namespace GitVersion.Core.Tests.Formatting;

namespace GitVersion.Tests.Formatting;

asbjornu · 2025-08-14T12:07:00Z

src/GitVersion.Core/Core/RegexPatterns.cs

@@ -93,7 +93,7 @@ internal static partial class Common
                    |                                                   # OR
                    (?<member>[A-Za-z_][A-Za-z0-9_]*)                   # member/property name
                    (?:                                                 # Optional format specifier
-                        :(?<format>[A-Za-z0-9\.\-,]+)                   # Colon followed by format string (no spaces, ?, or }), format cannot contain colon
+                        :(?<format>[A-Za-z0-9\.\-,;'"]+)                # Colon followed by format string (including semicolons and quotes)


9swampy added 2 commits August 13, 2025 22:56

Red

32b8c05

Green

c757b53

9swampy force-pushed the FormatNoFormat branch from 7048ae1 to 5e1c165 Compare August 13, 2025 23:05

9swampy force-pushed the FormatNoFormat branch 3 times, most recently from 3510bed to 8a331e5 Compare August 13, 2025 23:19

Refactor

3629aef

9swampy force-pushed the FormatNoFormat branch from 8a331e5 to 3629aef Compare August 13, 2025 23:25

Documentation

6245782

9swampy commented Aug 13, 2025

View reviewed changes

9swampy added 2 commits August 14, 2025 01:53

Red

7e0c492

Green

0708d23

arturcic requested review from arturcic and asbjornu and removed request for arturcic August 14, 2025 04:43

asbjornu requested changes Aug 14, 2025

View reviewed changes

asbjornu mentioned this pull request Aug 15, 2025

[ISSUE] Incorrect output for assembly-informational-version #4654

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Format no format #4657

Format no format #4657

Uh oh!

9swampy commented Aug 13, 2025 •

edited

Loading

Uh oh!

9swampy commented Aug 13, 2025

Uh oh!

9swampy Aug 13, 2025

Uh oh!

asbjornu Aug 14, 2025

Uh oh!

sonarqubecloud bot commented Aug 14, 2025

Uh oh!

9swampy commented Aug 14, 2025

Uh oh!

asbjornu left a comment

Uh oh!

asbjornu Aug 14, 2025

Uh oh!

asbjornu Aug 14, 2025

Uh oh!

asbjornu Aug 14, 2025

Uh oh!

asbjornu Aug 14, 2025

Uh oh!

asbjornu Aug 14, 2025

Uh oh!

asbjornu Aug 14, 2025

Uh oh!

asbjornu Aug 14, 2025

Uh oh!

asbjornu Aug 14, 2025

Uh oh!

Uh oh!

	namespace GitVersion.Core.Tests.Formatting;
	namespace GitVersion.Tests.Formatting;

Format no format #4657

Are you sure you want to change the base?

Format no format #4657

Uh oh!

Conversation

9swampy commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix legacy .NET composite format syntax

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

Uh oh!

9swampy commented Aug 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 14, 2025

Quality Gate passed

Uh oh!

9swampy commented Aug 14, 2025

Uh oh!

asbjornu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

9swampy commented Aug 13, 2025 •

edited

Loading