Skip to content

Add local project file location to exception when parsing fails #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Add local project file location to exception when parsing fails #3179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/GitVersion.Core/VersionConverters/AssemblyInfo/ProjectFileUpdater.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,15 @@ public void Execute(VersionVariables variables, AssemblyInfoContext context)
var localProjectFile = projectFile.FullName;

var originalFileContents = this.fileSystem.ReadAllText(localProjectFile);
var fileXml = XElement.Parse(originalFileContents);
XElement fileXml;
try
{
fileXml = XElement.Parse(originalFileContents);
}
catch (XmlException e)
{
throw new XmlException($"Unable to parse file as xml: {localProjectFile}", e);
}

if (!CanUpdateProjectFile(fileXml))
{
Expand Down