Avoid throwing WarningException by skip call gitPreparer when building a tagged version #2933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen building a tagged version.
asbjornu
changed the title
asbjornu
requested changes
Dec 6, 2021
Member
asbjornu
left a comment
asbjornu
left a comment
There was a problem hiding this comment.
This looks benign enough, but could you please add a test that provokes the problem?
Contributor
Author
|
@asbjornu unit tests added |
Contributor
|
Thank you @jhy871167495 for your contribution! |
hyabean
pushed a commit
to hyabean/GitVersion
that referenced
this pull request
Dec 27, 2021
5 tasks
hyabean
pushed a commit
to hyabean/GitVersion
that referenced
this pull request
Dec 28, 2021
This was referenced Dec 28, 2021
asbjornu
added a commit
that referenced
this pull request
Mar 5, 2022
invalid use of Lazy<GitVersionContext>, #2933 fix doesn't work actualy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2927
Description
if GitVersionContext.IsCurrentCommitTagged is true, skip call the IGitPreparer.Prepare method.
Related Issue
Fixes #2927
Motivation and Context
build failed on a CI agent (JENKINS), while it success on a workstation.
How Has This Been Tested?
Tested the Reproduce case in #2927
Screenshots (if appropriate):
Checklist: