Skip to content

Try updating PackageVersion_LibGit2Sharp to see if it will work now #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Try updating PackageVersion_LibGit2Sharp to see if it will work now #1708

wants to merge 2 commits into from

Conversation

derwasp
Copy link
Contributor

@derwasp derwasp commented Jun 18, 2019

No description provided.

@arturcic
Copy link
Member

There is already a work in progress PR for #1659, it's not only about nuget package update, it's also about the way it's packaged the msbuild Task and the way the native binaries are loaded

@derwasp
Copy link
Contributor Author

derwasp commented Jun 18, 2019

There is already a work in progress PR for #1659, it's not only about nuget package update, it's also about the way it's packaged the msbuild Task and the way the native binaries are loaded

Yeah, I saw that. That's why it's a draft :) It's just you already have the CI set up so I can get feedback on where what's failing while I poke around it.

@derwasp
Copy link
Contributor Author

derwasp commented Jun 19, 2019

@arturcic I wanted to ask you and @asbjornu (as I saw his messages regarding this update issue) if you guys considered releasing the updated version w/o msbuild support for the time being?
I saw that @asbjornu made an attempt of doing it in #1642, but something didn't work out for him and the build didn't pass.
I see that currently there are a few issues (if I understood everything correctly of course):

  • GitVersion doesn't work on e.g. Ubuntu 18.04 (my case).
  • Updating LibGit2Sharp breaks the msbuild task.
  • Fixing the msbuild task requires fiddling, because of the way new native dependencies are distributed.

In any case, it's a bit broken at the moment. If you can release the version w/o msbuild support as even alpha and not beta it could fix the issue I have at the moment. And in the mean time the work on creating a proper msbuild task can continue.
As in #1483 people mentioned that the new LibGit2Sharp fixes the Ubuntu problem. So I am not the only one who would benefit.

Is there a chance that you can consider it?

@derwasp derwasp closed this Jun 24, 2019
@derwasp derwasp deleted the feature/update-PackageVersion_LibGit2Sharp branch June 24, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants