Skip to content

CommandLine showvariable support in .NET Core #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2018
Merged

CommandLine showvariable support in .NET Core #1502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2c6923
Fixes #1469
snovak7 Oct 16, 2018
eb9f090
Merge branch 'master' into feature/1469-dotnet-version-variable
snovak7 Oct 17, 2018
8dfa5e9
Merge branch 'master' into feature/1469-dotnet-version-variable
snovak7 Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions src/GitVersionCore/OutputVariables/VersionVariables.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,7 @@ public string this[string variable]

get
{
#if NETDESKTOP
return typeof(VersionVariables).GetProperty(variable).GetValue(this, null) as string;
#else
throw new NotImplementedException();
// return typeof(VersionVariables).GetTypeInfo().GetProperty(variable).GetValue(this, null) as string;
#endif



}
}

Expand Down Expand Up @@ -193,16 +185,11 @@ public bool TryGetValue(string variable, out string variableValue)

public bool ContainsKey(string variable)
{
#if NETDESKTOP
return typeof(VersionVariables).GetProperty(variable) != null;
#else
throw new NotImplementedException();
// return typeof(VersionVariables).GetTypeInfo().GetProperty(variable) != null;
#endif
}

sealed class ReflectionIgnoreAttribute : Attribute
{
}
}
}
}