Skip to content

Update GitReleaseNotes #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2018
Merged

Update GitReleaseNotes #1438

merged 1 commit into from
Jul 4, 2018

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Jul 3, 2018

  • Updated to latest version of GitReleaseNotes to fix the ssl issue when generating release notes
  • fixed the version back to 4.0.0

@arturcic arturcic mentioned this pull request Jul 3, 2018
Merged
gep13
gep13 approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Jul 4, 2018

@arturcic thank you for taking the time to update this. Let's get this merged, and see if it helps with the error that was occurring.

@gep13 gep13 merged commit c90abfd into GitTools:master Jul 4, 2018
@gep13
Copy link
Member

gep13 commented Jul 4, 2018

@arturcic so, I don't "think" the failed build is unexpected, as I think it still expecting that the path to the releasenotes is present, which it isn't when the releasenotes are being created.

I will try to take the current build for a spin later to see if I can get that part to work. Unless someone gets to it before me.

@gep13
Copy link
Member

gep13 commented Jul 4, 2018

@arturcic looks like the build number is correctly working now, so thanks for making that change!

@arturcic
Copy link
Member Author

arturcic commented Jul 4, 2018

I guess we just need to check if build folder exists and create it if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturcic @gep13