Updated Dockerfile to build slim image #1357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base image is now just debian slim. Minimal required packages are installed. Release is taken exactly from github releases.
|
This will break the docker image publish: Line 191 in 3172ff9 |
|
The change itself looks good, if you can just change the source of the gitversion binary so release will still be automated |
|
@VEnis This was implemented as part of this PR #1485. Can you have a look at dotnetcore and close this PR? The linux image is based on microsoft/dotnet:2.1-runtime, that is based on debian:stretch-slim. |
|
Closing this as it was implemented in #1485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base image is now just debian slim.
Minimal required packages are installed.
Release is taken exactly from github releases (latest stable release used).
Size of the built image is just 222MB