Add configuration parameter to format CommitDate #1305

[ccHanibal]

As requested in #1305

[asbjornu]

Looks good! Just a couple of comments and this LGTM.

[asbjornu]

Since the test case formats are constant strings, please add them as regular [TestCase] attributes instead of the more complicated TestCaseData.

[asbjornu]

Is it perhaps a good idea to pass in CultureInfo.InvariantCulture here, just to avoid potential i18n problems or is it a "feature" that the date can be formatted in the locale of the process GitVersion is run under?

[ccHanibal]

I adopted your advices. Please review them.

[asbjornu]

Perfect! Can you please do a rebase of this branch on top of HEAD of master? This is how you do it:

git checkout master
git fetch upstream
git merge upstream/master
git checkout feature-commitdateformatconfigurable
git rebase master
git push --force

If you don't have the remote upstream defined, then do this before the above:

git remote add upstream [email protected]:GitTools/GitVersion.git

If you have any questions, please don't hesitate to ask. Thanks!

[ccHanibal]

Sure I'll give it a try. Never done that before.

[asbjornu]

@ccHanibal: Looks like that worked. Thanks!