Skip to content

Commit dcc9c2b

Browse files
committed
Review issues fixed
1 parent 68285ff commit dcc9c2b

File tree

2 files changed

+8
-22
lines changed

2 files changed

+8
-22
lines changed

src/GitVersionCore.Tests/CommitDateTests.cs

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -11,29 +11,15 @@ namespace GitVersionCore.Tests
1111
[TestFixture]
1212
public class CommitDateTests
1313
{
14-
public static IEnumerable<TestCaseData> CommitDateFormatTestCases
15-
{
16-
get
17-
{
18-
var date = new DateTime(2017, 10, 6);
19-
20-
var testCasesFormats = new[]
21-
{
22-
"yyyy-MM-dd",
23-
"dd.MM.yyyy",
24-
"yyyyMMdd",
25-
"yyyy-MM"
26-
};
27-
28-
foreach (var format in testCasesFormats)
29-
yield return new TestCaseData(date, format, date.ToString(format));
30-
}
31-
}
32-
3314
[Test]
34-
[TestCaseSource(nameof(CommitDateFormatTestCases))]
35-
public void CommitDateFormatTest(DateTime date, string format, string expectedOutcome)
15+
[TestCase("yyyy-MM-dd", "2017-10-06")]
16+
[TestCase("dd.MM.yyyy", "06.10.2017")]
17+
[TestCase("yyyyMMdd", "20171006")]
18+
[TestCase("yyyy-MM", "2017-10")]
19+
public void CommitDateFormatTest(string format, string expectedOutcome)
3620
{
21+
var date = new DateTime(2017, 10, 6);
22+
3723
var formatValues = new SemanticVersionFormatValues(
3824
new SemanticVersion
3925
{

src/GitVersionCore/SemanticVersionFormatValues.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public string Sha
109109

110110
public string CommitDate
111111
{
112-
get { return _semver.BuildMetaData.CommitDate.UtcDateTime.ToString(_config.CommitDateFormat); }
112+
get { return _semver.BuildMetaData.CommitDate.UtcDateTime.ToString(_config.CommitDateFormat, CultureInfo.InvariantCulture); }
113113
}
114114

115115
// TODO When NuGet 3 is released: public string NuGetVersionV3 { get { return ??; } }

0 commit comments

Comments
 (0)