Skip to content

[Fix]MetalView scale calculation (#61) #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

[Fix]MetalView scale calculation (#61) #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions sdk/objc/components/renderer/metal/RTCMTLVideoView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,25 +137,13 @@ - (void)setMultipleTouchEnabled:(BOOL)multipleTouchEnabled {
}
#endif

- (CGFloat)currentScaleFactor {
CGFloat scale = 1.0;
#if TARGET_OS_IPHONE
scale = [UIScreen mainScreen].scale;
#elif TARGET_OS_OSX
scale = [NSScreen mainScreen].backingScaleFactor;
#endif
return MAX(scale, 1.0);
}

- (void)performLayout {
CGRect bounds = self.bounds;
self.metalView.frame = bounds;
if (!CGSizeEqualToSize(self.videoFrameSize, CGSizeZero)) {
self.metalView.drawableSize = [self drawableSize];
} else {
// Apply scale factor for default size as well (when videoFrameSize is zero)
CGFloat scale = [self currentScaleFactor];
self.metalView.drawableSize = CGSizeMake(bounds.size.width * scale, bounds.size.height * scale);
self.metalView.drawableSize = bounds.size;
}
}

Expand Down Expand Up @@ -258,16 +246,11 @@ - (CGSize)drawableSize {
BOOL sizeIsLandscape = (self.videoFrame.rotation == RTC_OBJC_TYPE(RTCVideoRotation_0)) ||
(self.videoFrame.rotation == RTC_OBJC_TYPE(RTCVideoRotation_180));

CGSize size;
if (useLandscape == sizeIsLandscape) {
size = videoFrameSize;
return videoFrameSize;
} else {
size = CGSizeMake(videoFrameSize.height, videoFrameSize.width);
return CGSizeMake(videoFrameSize.height, videoFrameSize.width);
}

// Apply scale factor for retina displays
CGFloat scale = [self currentScaleFactor];
return CGSizeMake(size.width * scale, size.height * scale);
}

#pragma mark - RTC_OBJC_TYPE(RTCVideoRenderer)
Expand Down