Always show FloatingParticipantVideo in calls #1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SDK Size Comparison 📏
|
liviu-timar
force-pushed
the
and-553-always-show-floatingparticipantvideo
branch
from
1013761 to
1d7c153
Compare
|
aleksandar-apostolov
approved these changes
May 16, 2025
aleksandar-apostolov
deleted the
and-553-always-show-floatingparticipantvideo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Currently, we show the FloatingParticipantVideo contents only if
track != null. This makes the component visible only when joining with the camera on and hidden when joining with camera off, hence a UI discrepancy.🛠 Implementation details
🧪 Testing