Make message spacing in message list configurable #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a message group configurable
laevandus
reviewed
May 19, 2025
Comment on lines
110
to
111
| public let messageListItemSpacing: CGFloat | ||
| public let messageGroupItemSpacing: CGFloat |
There was a problem hiding this comment.
Could you please do some minor changes. Since we already have MessagePaddings struct then please add these values to there:
groupBottomsingleBottom
Could you please CHANGELOG entry as well following the format we have there. Would go under Added section.
There was a problem hiding this comment.
Thanks for your review @laevandus . I've updated the code to address your comment above. Please help me check again.
laevandus
approved these changes
May 20, 2025
laevandus
added a commit
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
N/A
🎯 Goal
Make following spacings configurable:
🛠 Implementation
Create new params for
MessageListConfigto configure these spacings and use them inMessageContainerView.🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
☑️ Contributor Checklist
docs-contentrepo