Skip to content

Conversation

pnc
Copy link

@pnc pnc commented Nov 29, 2018

This is a partial change, since it's not clear to me what the boolean parameter indicates.

For instance, if you change your vehicle, the function is called with false, "Workflow". What does the boolean parameter mean?

This is a partial change, since it's not clear to me what the `boolean` parameter indicates.

For instance, if you change your vehicle, the function is called with `false, "Workflow"`. What does the boolean parameter mean?
@colonelchlorine
Copy link
Contributor

@pnc still in dev. first parameter represents whether driver action is necessary (true for action started, false for action complete).

might switch it to two different event functions with a single 'action type' parameter that is being started / completed.

@pnc
Copy link
Author

pnc commented Dec 20, 2018

@colonelchlorine This shipped in 1804 and we're now relying on it in production code, based on Vik Sridhar's guidance, so this needs to stay stable.

What's the second parameter?

@colonelchlorine
Copy link
Contributor

This is not in full release. You're doing a PR on a branch. Proceed with caution in production.

A string which represents the area of the application (e.g. "workflow" or "login")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants