Skip to content

Fix sort parameter handling #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix sort parameter handling #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mygeotab/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,14 @@ def get(self, type_name, **parameters):
if results_limit is not None:
del parameters["results_limit"]

sort = parameters.get("sort")
if sort is not None:
del parameters["sort"]

if "search" in parameters:
parameters.update(parameters["search"])
del parameters["search"]
parameters = dict(search=parameters, resultsLimit=results_limit)
parameters = dict(search=parameters, resultsLimit=results_limit, sort=sort)
return self.call("Get", type_name=type_name, **parameters)

def add(self, type_name, entity):
Expand Down