Handle non-parseable values in attributes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atlefren
changed the title
|
Just now getting to this. I need to think about it some more. On the one hand, I love it when things just work and a library doesn't bother me with minutia. But on the other hand, I could also see this change driving somebody nuts trying to figure out why a value is returned as None. The comprise might be the flag you mentioned for "strict" handling or similar. Definitely worth more discussion. |
GeospatialPython
added a commit
that referenced
this pull request
Feb 8, 2016
Handle non-parseable values in attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For shapefiles with values that cannot be cast to float or int in the attributes the lib dies with a ValueError. I think it's cleaner to then set the value to None. This is consistent with how QGIS handles these shapefiles and should not cause much trouble.
If this causes trouble it's possible to add a flag to either die on error or set to None.