Tests try versions of python that are not supported

[schwehr]

PyShp Version

head - 546489e

Python Version

all

Your code

This is just the github CI action running

Full stacktrace

test_on_old_Pythons (3.5)
failed 47 minutes ago in 7s
Search logs
1s
3s
1s
0s
Prepare all required actions
Run ./.github/actions/test
Run python shapefile.py
  File "shapefile.py", line 643
    return f"Shape #{self.__oid}: {self.shapeTypeName}"
                                                      ^
SyntaxError: invalid syntax
Error: Process completed with exit code 1.

Other notes

Definitely should not be testing python 3.5-3.8. And supporting python 2.7 is pretty hard, so that should probably go too.

Additionally, it seems overly heavy to run every python version through ubuntu, windows, and mac osx. I typically recommend doing every python version on ubuntu and then one python version for each of macosx and windows. And if it's doing ubuntu latest, drop all (or maybe keep one) ubuntu 24.04.

[JamesParrott]

We've had a discussion live since September, that pinged all the contributors to PyShp. Just under two weeks ago I emailed about 160 projects that use PyShp, and suppport these older PYthons themselves. Nobody's objected to PyShp dropping support for 2.7 and 3.5 - 3.9 so far, and without further objections over the weekend, next week I'll start work on PyShp version 3 that will drop support for these.

The test failures are due to an external dependency in the tests (to download a shapefile from) that's not caused any trouble until now.