When using scrcpy 3.0 on some devices, no new SPS frames are generated when the device is rotated.

[sbfkcel]

Environment

• OS: macOS
• Scrcpy version: 3.0
• Installation method: github release
• Device model: HUAWEI ANA-AN00
• Android version: 12

Describe the bug

When the device screen rotates, the scrcpy screen does not rotate.
If you use scrcpy 2.7, everything is normal.

After preliminary investigation, when using scrcpy 3.0, when the device screen rotates, the SPS frame should change, but no new SPS frame is generated on this device.

➜ scrcpy
scrcpy 3.0 <https://github.com/Genymobile/scrcpy>
INFO: ADB device found:
INFO:     -->   (usb)  KXU0221408005112                device  ANA_AN00
/opt/homebrew/Cellar/scrcpy/3.0/share/scrcpy/scrcpy-server: 1 file pushed, 0 skipped. 133.6 MB/s (90224 bytes in 0.001s)
[server] INFO: Device: [HUAWEI] HUAWEI ANA-AN00 (Android 12)
INFO: Renderer: metal
INFO: Texture: 1080x2336
2024-11-26 09:48:43.848 scrcpy[30447:5761806] +[IMKClient subclass]: chose IMKClient_Modern
2024-11-26 09:48:43.848 scrcpy[30447:5761806] +[IMKInputSession subclass]: chose IMKInputSession_Modern
[server] ERROR: Exception on thread Thread[DisplayListener,5,main]
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.contains(java.lang.CharSequence)' on a null object reference
	at android.hardware.display.DisplayManagerGlobal$DisplayListenerDelegate.handleMessage(DisplayManagerGlobal.java:1000)
	at android.os.Handler.dispatchMessage(Handler.java:117)
	at android.os.Looper.loopOnce(Looper.java:205)
	at android.os.Looper.loop(Looper.java:293)
	at android.os.HandlerThread.run(HandlerThread.java:110)

[rom1v]

Please post your framework.jar:

adb pull /system/framework/framework.jar

[sbfkcel]

Please download and unzip it.

framework.jar.zip

[rom1v]

The custom ROM on your device added:

                        if (this.mListener.toString().contains(DisplayManagerGlobal.TARGET_PACKAGE_NAME)) {
                            Log.i(DisplayManagerGlobal.TAG, "Prepare Notification launcher onDisplayChanged");
                        }

This should fix the issue:

diff --git server/src/main/java/com/genymobile/scrcpy/wrappers/DisplayManager.java server/src/main/java/com/genymobile/scrcpy/wrappers/DisplayManager.java
index b497e97fa..d44ac608f 100644
--- server/src/main/java/com/genymobile/scrcpy/wrappers/DisplayManager.java
+++ server/src/main/java/com/genymobile/scrcpy/wrappers/DisplayManager.java
@@ -192,6 +192,9 @@ public final class DisplayManager {
                         if ("onDisplayChanged".equals(method.getName())) {
                             listener.onDisplayChanged((int) args[0]);
                         }
+                        if ("toString".equals(method.getName())) {
+                            return "DisplayListener";
+                        }
                         return null;
                     });
             try {

Please test by replacing this file in scrcpy 3.0:

• scrcpy-server SHA-256: 5c9c99c4c8efa6dddc887a0f92c62837ec0cceaf398475689de272cc4954c8a

[sbfkcel]

Cool, tested and verified that the issue is fixed.

[rom1v]

Merged: 3e68902