Skip to content

Remove annotated frame from the image for the remote dataset "GSHHG Global Earth Mask" #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yvonnefroehlich opened this issue Oct 10, 2023 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@yvonnefroehlich
Copy link
Member

This is related to the comment at GenericMappingTools/pygmt#2728 (comment) by @seisman.

Compared to the images of the other remote datasets, the image of the GSHHG Global Earth Mask remote dataset has a fancy frame and annotations (please see https://www.generic-mapping-tools.org/remote-datasets/). This does not look well and is inconsistent. Thus it is suggested to update this image with a version without the annotated fancy frame.

@PaulWessel
Copy link
Member

Agreed, maybe @Esteban82 has time? I’m on my way to an Oslo dinner/show!

@Esteban82
Copy link
Member

I have some time.

Should I only delete -Baf -BWsNe in GMT_earthmask.sh?

@Esteban82
Copy link
Member

And maybe I could edit the maps of the Crustal Age and geoid and center them at 0 (instead of 180).

@yvonnefroehlich
Copy link
Member Author

I have some time.

Should I only delete -Baf -BWsNe in GMT_earthmask.sh?

Yes, I think so.

@yvonnefroehlich
Copy link
Member Author

And maybe I could edit the maps of the Crustal Age and geoid and center them at 0 (instead of 180).

I think this is a good idea, because I feel it's good to have the images consistent for all remote datasets.

@Esteban82
Copy link
Member

Yes, I think so.

Ok. let's try. I also updated the png file.

@yvonnefroehlich
Copy link
Member Author

yvonnefroehlich commented Oct 10, 2023

I am just wondering, whether we should addionaly move the legend for Earth mask inside the image similar to colorbar for Earth Seafloor Crustal Age?

Edit: Just saw you already did this change in the PR 🙂 !

@Esteban82
Copy link
Member

Esteban82 commented Oct 10, 2023

I move it a bit upwards but no as much as for the Earth Seafloor Crustal Age. In this map, the legend is over Antarctica.

@Esteban82 Esteban82 self-assigned this Oct 10, 2023
@Esteban82 Esteban82 added the bug Something isn't working label Oct 10, 2023
@Esteban82
Copy link
Member

Esteban82 commented Oct 10, 2023

Fixed by #85.

@Esteban82
Copy link
Member

And maybe I could edit the maps of the Crustal Age and geoid and center them at 0 (instead of 180).

@PaulWessel is there a script to make all the others statics images (beside AGE and Earthmask)? Should I make it?

@PaulWessel
Copy link
Member

Please do, I think those were one liners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants