-
Notifications
You must be signed in to change notification settings - Fork 229
Changes to speed up Earth relief and regions tutorials #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to speed up Earth relief and regions tutorials #868
Conversation
@seisman This doesn't appear to have changed the times to build the documentation; any ideas on how to improve it? |
Might need to merge in the change from #866 first to use the cache properly. |
Merging the changes from #866 doesn't seem to have sped up the tests. |
I'm afraid the key reason for the slow execution time is because there are too many figures in these tutorials (7 for 3d perspective figure and 11 for regions). For example, in the 3d perspective figure, can we merge the last few (~3) figures into one figure? |
Here is what we can do to improve the 3D respective tutorial:
|
Closing this PR due to creating multiple branches and pushing them; discussion/further edits will be at #871 |
Makes the changes suggested for
regions.py
andearth-relief.py
to reduce the time to generate the tutorials. This PR removes the internal national borders inregions.py
and changes the land color to dark gray. It also changes theregistration
for the loaded Earth relief grid to "gridline" because that is the cached version.Fixes #825
Reminders
make format
andmake check
to make sure the code follows the style guide.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version