-
Notifications
You must be signed in to change notification settings - Fork 228
DOC: Complete list of aliases #3945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seisman
wants to merge
8
commits into
main
Choose a base branch
from
doc/alias-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
227e80c
DOC: Complete list of aliases
seisman 71a9126
New style for list of aliases
seisman 8529daf
Merge branch 'main' into doc/alias-list
seisman 710dde2
Merge branch 'main' into doc/alias-list
seisman 4fa8af8
Merge branch 'main' into doc/alias-list
seisman 093e630
Merge branch 'main' into doc/alias-list
seisman dcf8605
Merge branch 'main' into doc/alias-list
seisman 9358dc1
Merge branch 'main' into doc/alias-list
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
{aliases}
placeholder will be expanded to something like:Currently, the solution is to add the missing aliases below the
{aliases}
placeholder. Does it look bad? Perhaps we should maintain the full list of aliases manually, i.e., remove the{aliases}
placeholder and manually add all aliases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the changes in
grdfill.py
for another style.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my current understanding, I prefer the style of
grdfill.py
.An overall alphabetical order makes it much easier to find a specific alias within the list.
The missing aliases have to be added manually anyway. As the aliases directly related to GMT flags will very likely not change (and if only very little), I think we have to add the list of these aliases and then this should be fine.