Skip to content

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 13, 2024

Description of proposed changes

No code changes. Just add type hints and improve docstrings.

Related to #2794.

@seisman seisman added needs review This PR has higher priority and needs review. typing Type hints and static type checking labels Aug 13, 2024
@seisman seisman added this to the 0.13.0 milestone Aug 13, 2024
@seisman seisman requested a review from a team August 23, 2024 01:37
@seisman seisman changed the title TYP: Add type hints to the Figure.savefig method and update docstrings Figure.savefig: Add type hints and improve docstrings Aug 23, 2024
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Aug 23, 2024
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Aug 28, 2024
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 29, 2024
@seisman seisman merged commit f5d8672 into main Aug 29, 2024
17 of 20 checks passed
@seisman seisman deleted the typing/savefig branch August 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip adding Pull Request to changelog typing Type hints and static type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants