Skip to content

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Sep 2, 2023

Description of proposed changes

This PR aims to update the Teams Gallery reagarding Yvonne becoming a Maintainer of PyGMT.
For context see the discussion up on #2651 (comment).

Preview: https://pygmt-dev--2655.org.readthedocs.build/en/2655/team.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added the skip-changelog Skip adding Pull Request to changelog label Sep 2, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.11.0 milestone Sep 2, 2023
@yvonnefroehlich yvonnefroehlich self-assigned this Sep 2, 2023
@yvonnefroehlich yvonnefroehlich mentioned this pull request Sep 2, 2023
15 tasks
@seisman seisman added the maintenance Boring but important stuff for the core devs label Sep 3, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Sep 3, 2023
@seisman seisman merged commit 9d1dd10 into main Sep 4, 2023
@seisman seisman deleted the update-team-YF branch September 4, 2023 04:12
@seisman
Copy link
Member

seisman commented Sep 4, 2023

@yvonnefroehlich Following the access checklist in PR #2656, I've added you to the pygmt-maintainers team, and also removed you from the pygmt-contributors team. Please note that pygmt-maintainers is a child team of pygmt-contributors, so I presume you still will receive notification when some ping the @GenericMappingTools/pygmt-contributors team.

@yvonnefroehlich
Copy link
Member Author

@yvonnefroehlich Following the access checklist in PR #2656, I've added you to the pygmt-maintainers team, and also removed you from the pygmt-contributors team.

Sound good - thanks @seisman 🙂!

Please note that pygmt-maintainers is a child team of pygmt-contributors, so I presume you still will receive notification when some ping the @GenericMappingTools/pygmt-contributors team.

No worries, that's no problem for me at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants