-
Notifications
You must be signed in to change notification settings - Fork 229
A gallery example for the contour method #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A gallery example for the contour method #1387
Conversation
💖 Thanks for opening this pull request! 💖 Please make sure you read our contributing guidelines and abide by our code of conduct. A few things to keep in mind:
|
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @yohaimagen; thanks for addressing this issue! I have made a few suggestions on this pull request. If you agree with the suggestions, you can commit the changes using these steps:
- Click on the 'Files changed' tab in the pull request
- For each comment, you can click 'commit suggestion' in order to commit the suggestions one at a time or click 'add suggestion to batch', which allows you to commit multiple suggestions at once. If you plan to accept multiple suggestions, I recommend using the 'add suggestion to batch' option.
2a. If you clicked 'commit suggestion', you'll see a pop-up where you can enter a descriptive commit message and then click 'commit changes'.
2b. If you clicked 'add suggestion to batch', after reviewing all the suggestions, you can click 'commit suggestions' near the top of the 'files changed' tab. This will similarly prefill a commit message and allow you to commit the changes.
Feel free to reach out if you have any questions!
…ce to numpy ndarray, adding units to pen.
Sorry, I didn't saw your suggestions before adding some of my own, I incorporate some of your suggestions into mine. |
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, your revisions are great! I have made a set of small comments, mostly related to sphinx formatting, which can be really particular. I also recommended to increase the contour spacing from 5 to 10 in order to make it easier to see the difference between the contour spacing and the annotation spacing.
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Great, I committed all of your suggestions @meghanrjones. I think that this gallery example is done :) |
One last thing, maybe it will be better to put this example under "Images, contours, and fields" than under "Lines and vectors". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
We usually leave approved pull requests open for ~1 day or until we get a second approval before merging, just in case other maintainers see anything major that needs adjusting.
Co-authored-by: Will Schlitzer <[email protected]>
🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉 Please open a new pull request to add yourself to the |
Great work @yohaimagen, congratulations on merging the PR! 🎉 We hope to see you around more 😄 |
Cheers @yohaimagen! Your gallery example is now live at https://www.pygmt.org/dev/gallery/index.html#images-contours-and-fields. Well done! 🥳 |
* Initial commit for contour gallery example * Explain the acceptable data formats, levels, and annotation parameters. * Add a bit more explanation on the implementation, adding a reference to numpy ndarray, adding units to pen. Co-authored-by: Meghan Jones <[email protected]> Co-authored-by: Will Schlitzer <[email protected]>
Description of proposed changes
In response to issue #1340 adding a gallery example for the contour method.
Fixes #1340
Preview at https://pygmt-git-fork-yohaimagen-contour-gallery-example-gmt.vercel.app/gallery/images/contours.html
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version