-
Notifications
You must be signed in to change notification settings - Fork 232
Added documentation for three oblique mercator projections #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💖 Thanks for opening this pull request! 💖 Please make sure you read our contributing guidelines and abide by our code of conduct. A few things to keep in mind:
|
Thanks for opening this PR @eemcmullan. Unfortunately it seems like @willschlitzer started to work on this topic this morning in #1250. Maybe you can bundle up your efforts? |
@michaelgrund Ahh I see that now. Of course, I can reach out to him about bundling! |
I reviewed these suggestions, and appreciate the feedback! Thank you for the improvements. Co-authored-by: Will Schlitzer <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
Thanks for submitting this pull request! Could you please add links to these projection examples in the projection table as part of this pull request? The source text for the projection table is in examples/projections/table/README.txt. There are three lines (L56, L58, and L60) that need to be updated, for example:
will link to the first example if it is changed to this:
|
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me. Thanks, @eemcmullan.
@michaelgrund @willschlitzer Please give it approval if you're OK with the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for this addition, @eemcmullan!
I was happy to do so! Thanks all for your help! @willschlitzer @seisman @michaelgrund @meghanrjones |
@meghanrjones Please give it a final review and feel free to merge it with your admin permission, since the original issue #1073 was opened by you. |
🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉 Please open a new pull request to add yourself to the |
…#1251) Co-authored-by: Will Schlitzer <[email protected]> Co-authored-by: Michael Grund <[email protected]> Co-authored-by: Dongdong Tian <[email protected]>
Description of proposed changes
Added three files to examples/projections/cyl for the three different oblique mercator projections. Included a brief definition of oblique mercator projections, descriptions for each option, as well as working code examples. This is in response to issue #1073. Please let me know if something needs to be fixed; I would be more than happy to change it!
Fixes #1073
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version