Skip to content

API documentations generated by sphinx 2.x are unreadable #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seisman opened this issue May 2, 2019 · 5 comments · Fixed by #306
Closed

API documentations generated by sphinx 2.x are unreadable #305

seisman opened this issue May 2, 2019 · 5 comments · Fixed by #306
Labels
documentation Improvements or additions to documentation help wanted Helping hands are appreciated

Comments

@seisman
Copy link
Member

seisman commented May 2, 2019

Description of the problem

See https://www.pygmt.org/dev/api/generated/pygmt.Figure.basemap.html or the screenshot below:
image

This is caused by the recent update of sphinx 2.x and the inconsistence between sphinx 2.x and sphinx_rtd_theme. See readthedocs/sphinx_rtd_theme#752 for the description of the bug.

We should use sphinx<=1.8.5 now.

@seisman
Copy link
Member Author

seisman commented May 3, 2019

The API lists are not still rendered correctly.
image

See https://www.pygmt.org/dev/api/index.html#plotting

@leouieda
Copy link
Member

leouieda commented May 3, 2019

You're right. I hand't notice when that I downgraded. I'll try 1.8.3

@seisman
Copy link
Member Author

seisman commented May 3, 2019

1.8.5 works locally for me.

@leouieda
Copy link
Member

leouieda commented May 7, 2019

From numpy/numpydoc#215 this problem seems to be a combination of sphinx, numpydoc, and the rtd theme. I get the same thing locally. For now, this is not good but not terrible. Let's keep this open so we know to fix it but I don't want to worry too much about it now.

@leouieda leouieda added documentation Improvements or additions to documentation help wanted Helping hands are appreciated labels May 7, 2019
@weiji14
Copy link
Member

weiji14 commented Mar 24, 2020

I'll close this as it should be resolved by the move to using the napolean sphinx extension in #383. Screenshot of https://www.pygmt.org/dev/api/generated/pygmt.Figure.basemap.html and https://www.pygmt.org/dev/api/index.html#plotting below:

basemap docs with new napolean sphinx

plotting api docs with new napolean sphinx

@weiji14 weiji14 closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Helping hands are appreciated
Projects
None yet
3 participants