Skip to content

Long-lasting bug with seniority finally killed in gmt_crossover function #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Long-lasting bug with seniority finally killed in gmt_crossover function #8188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61e55fb
Call gmt_crossover with ge = false for contour labels
PaulWessel Dec 12, 2023
b2fa4d0
Update gmt_support.c
PaulWessel Dec 12, 2023
41a3558
Update greenspline.dvc
PaulWessel Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gmt_support.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15436,7 +15436,7 @@ uint64_t gmt_crossover (struct GMT_CTRL *GMT, double xa[], double ya[], uint64_t

tx_a = ta_start + fabs (xc - xa[ta_start]) * i_del_xa;
tx_b = tb_start + fabs (xc - xb[tb_start]) * i_del_xb;
if (tx_a < ta_stop && tx_b < tb_stop) {
if (tx_a < ta_stop && tx_b <= tb_stop) { /* Equality means the crossing occurred on the second data node */
X->x[nx] = xc;
X->y[nx] = ya[xa_start] + (xc - xa[xa_start]) * slp_a;
X->xnode[0][nx] = tx_a;
Expand Down
4 changes: 2 additions & 2 deletions test/baseline/greenspline.dvc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
outs:
- md5: 346061c5e8dc2a44a7fe74e6a827c4ea.dir
size: 1581934
- md5: 416c79243026ec7b60578a5bb74cf8b8.dir
nfiles: 8
path: greenspline
hash: md5