Let histogram carefully bin data unless for very large data sets #5352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #5343 for background. By comparing a value to the array of bin boundaries we can consistently round in the same direction. However, for large data sets of more than 1 million points we will use a faster approach for equidstant bins where values that fall exactly on bin boundaries will be rounded in alternate directions per standard rounding conventions.
joa-quim
approved these changes
Jun 18, 2021
maxrjones
approved these changes
Jun 18, 2021
seisman
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5343 for background. By comparing a value to the array of bin boundaries we can consistently round in the same direction. However, for large data sets of more than 1 million points we will use a faster approach for equidistant bins where values that fall exactly on bin boundaries will be rounded in alternate directions per standard rounding conventions.
Hence, this is not really a bug fix per se as the original case is a clear user error of not using -F.