Skip to content

Conversation

maxrjones
Copy link
Member

Description of proposed changes

Note: To be merged into gh-pages brach

This PR removes the 6.2.0rc1 directory from the gh-pages branch because it is no longer published in the gmt documentation now that 6.2.0rc2 has been released.

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@vercel
Copy link

vercel bot commented May 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gmt/gmt/tbqsGCNZK2ZuwQCEGqeZYLkYdNv2
✅ Preview: https://gmt-git-remove-rc1-dir-gmt.vercel.app

@maxrjones
Copy link
Member Author

I think we should have review protections for the gh-pages branch similar to the master branch. What are your thoughts @seisman and @PaulWessel?

@maxrjones maxrjones mentioned this pull request May 25, 2021
38 tasks
@seisman
Copy link
Member

seisman commented May 25, 2021

I think it also means the bot can not deploy to the gh-pages branch.

@maxrjones
Copy link
Member Author

I think it also means the bot can not deploy to the gh-pages branch.

Thanks for the explanation - I did not realize that. I will still ask for reviews for my PRs.

@maxrjones maxrjones requested review from PaulWessel and seisman May 25, 2021 01:43
@maxrjones maxrjones merged commit 536e05c into gh-pages May 25, 2021
@maxrjones maxrjones deleted the remove-rc1-dir branch May 25, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants