Skip to content

Conversation

@h3o66
Copy link
Member

@h3o66 h3o66 commented Dec 28, 2020

Description

Adding a command to alert for an update for the server if it is updated by the steamcmd.
I did also a refactor to move all steamcmd related functions to a new core functions

Fixes #2001

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 added type: feature New feature or request type: refactor labels Dec 28, 2020
@h3o66 h3o66 requested a review from dgibbs64 December 28, 2020 20:19
@h3o66 h3o66 linked an issue Dec 28, 2020 that may be closed by this pull request
@dgibbs64 dgibbs64 changed the title feature(check-update): add check update feature for steamcmd games feat(check-update): add new command check-update for steamcmd game servers Dec 28, 2020
@dgibbs64 dgibbs64 added this to the v21.1.0 milestone Dec 29, 2020
dgibbs64
dgibbs64 previously approved these changes Dec 29, 2020
Copy link
Member

@dgibbs64 dgibbs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this and happy with the changes including creating core_steamcmd

@dgibbs64
Copy link
Member

Have the docs been updated to add the new command?

@h3o66
Copy link
Member Author

h3o66 commented Dec 29, 2020

Have the docs been updated to add the new command?

Added PR for the docs:
GameServerManagers/LinuxGSM-Docs#53

@h3o66 h3o66 force-pushed the feature/check-update branch from 33e6d20 to 519f3e7 Compare December 30, 2020 15:17
@h3o66 h3o66 force-pushed the feature/check-update branch from 519f3e7 to 4128446 Compare December 30, 2020 15:30
Copy link
Member

@dgibbs64 dgibbs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this

@dgibbs64 dgibbs64 merged commit a075300 into GameServerManagers:develop Dec 31, 2020
@h3o66 h3o66 deleted the feature/check-update branch December 31, 2020 13:16
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alert if Update available?

2 participants