Remove Unused Code #1581
Open
Remove Unused Code #1581
+299
−1,242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Dream-Master
added
the
🚧 Testing on Zeta
danyadev
requested changes
Jan 31, 2026
| @Override | ||
| public String getCommandUsage(ICommandSender p_71518_1_) { | ||
| public String getCommandUsage(ICommandSender sender) { | ||
| return "/hazarditems <action> [<parm1>, <parm2>, ..]"; |
Member
There was a problem hiding this comment.
you never used the dreamcraft.command.hazarditems.usage translation and I guess you forgot to add it here
| @@ -385,37 +383,9 @@ else if ("tconstruct.smeltery.itemblocks.LavaTankItemBlock" | |||
| private Field bg2ExtraInvField; | |||
|
|
||
| private static boolean isValidPotionID(int id) { | ||
| return id < 0 || id >= Potion.potionTypes.length || Potion.potionTypes[id] == null; | ||
| } |
Member
There was a problem hiding this comment.
does it really check that the potion is valid?
Contributor
Author
There was a problem hiding this comment.
Cripes, forgot to invert the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed:
InventoryItem- an unused classNotificationTickHandlerfor providing achievement-like popups to the player.use_machine_metal_tintGT config, since it wasn't correctly implemented anyways and there are better ways to change the machine metal tint color.To remove in future PRs:
MinetweakerFurnaceFixto a mixin in HodgepodgeShould be merged alongside GTNewHorizons/GT-New-Horizons-Modpack#23384