Implement the missing NEI integration pats, aswell as fix some bugs i found caused by missing code from 1.12.2

[rspforhp]

Most of the changed code is commented with reasons why i changed it, the NEI is probably not the best implementation, but its working and i think its good

[rspforhp]

discord username: miya_kopie

[rspforhp]

i think the interface needs doc/comments, but i dont really know how to write those good

[brachy84]

Not sure about the NEI parts. You need to adjust the code style. Use a space after ìf` and around operators. The opening { goes on the same line as the method declaration. Avoid multiple empty lines. Always use { } in if statements if they are multiline. Use lower camel case for field names (at StackPositioner). You added line breaks to some places for no reason.

[rspforhp]

Not sure about the NEI parts. You need to adjust the code style. Use a space after ìf` and around operators. The opening { goes on the same line as the method declaration. Avoid multiple empty lines. Always use { } in if statements if they are multiline. Use lower camel case for field names (at StackPositioner). You added line breaks to some places for no reason.

I come from c#, so i forgot to follow the java coding style
i think other repos have spotless to help with that, but i think this one is missing it, i do not know why

[rspforhp]

Is this better?

[brachy84]

I come from c#, so i forgot to follow the java coding style i think other repos have spotless to help with that, but i think this one is missing it, i do not know why

It's easier to sync with upstream this way.

[brachy84]

Is this better?

You barely did anything i asked for.

[rspforhp]

I come from c#, so i forgot to follow the java coding style i think other repos have spotless to help with that, but i think this one is missing it, i do not know why

It's easier to sync with upstream this way.

i see

[rspforhp]

Is this better?

You barely did anything i asked for.

i removed the line breaks, and put the { on the same line as the if, and used camel case, not sure what else there is? guess the spaces around operators?

[Dream-Master]

@brachy84 can you re check the pr? thanks

[sisyphussy]

I'll review in a couple hours once i'm on pc.

[rspforhp]

yeah thats okay

[sisyphussy]

also, could you clarify what exactly this PR fixes so i can better justify the code and what it's doing?

[rspforhp]

the fix for fluid slot was making sure it doesnt drain x fluid from fluid container if it doesnt have that amount
the container registry stuff was expected to return null on fail in a bunch of places, so i did that
crafting slot was always duping items on ground after finishing

[sisyphussy]

I haven't found any issues with the code, but this should probably get approved by a mui2 dev, since it does change some behaviour

[brachy84]

The mui part looks fine. No idea about the nei part