fix: reset consumed request stream when debug logging #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentbull
force-pushed
the
fix-request-logging-middleware
branch
from
3d72d12 to
6f2e543
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 98.64% 98.65% +0.01%
==========================================
Files 15 15
Lines 1036 1044 +8
Branches 127 128 +1
==========================================
+ Hits 1022 1030 +8
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The prior version of the RequestLoggerMiddleware would consume the request body stream with req.stream.read() which broke things because the stream is a one-shot IO read meaning that the stream must be reset in order to be later consumed by the Falcon HTTP request handler. The logging was also updated to use placeholders rather than f-strings for performance.
kentbull
force-pushed
the
fix-request-logging-middleware
branch
from
6f2e543 to
543fd75
Compare
The prior use of the /local directory with a raw "with open" call caused the tests to be brittle. The use of pathlib to dynamically load a relative path enables the tests to be runnable from any directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior version of the RequestLoggerMiddleware would consume the request body stream with req.stream.read() which broke HTTP POST requests (currently unused by the did:webs resolver) because the stream is a one-shot IO read meaning that the stream must be reset in order to be later consumed by the Falcon HTTP request handler. The logging was also updated to use placeholders rather than f-strings for performance.