-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add mesh statistic tools #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
add tests of helpers add test data files
…filter computation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things to correct, the plugins work.
The .rst file for PVPlugins needs to be updated to take into account the new architecture.
@@ -20,35 +20,35 @@ | |||
) | |||
|
|||
# update sys.path to load all GEOS Python Package dependencies | |||
geos_pv_path: Path = Path( __file__ ).parent.parent.parent | |||
geos_pv_path: Path = Path( __file__ ).parent.parent.parent.parent.parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to change our way to handle paths with ParaView in a new PR, I will make an issue for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree.
A few features will be handled in a future PR :
@alexbenedicto I added a brief documentation of the plugins that have been moved for now. I think it's best to dedicate a future PR to the improvement of the documentation of all the plugins as this one is already very large... |
This PR add a wrapper to vtkMeshQuality filter to compute all metric at once and export summary report. It also extend the squish index to all types of cell and add mesh quality metrics.