Skip to content

refactor: create geos-pv package #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 15, 2025
Merged

Conversation

mlemayTTE
Copy link
Contributor

@mlemayTTE mlemayTTE commented Apr 2, 2025

Closes #70

Need to copy geos-posp/src/visu/PVUtils/* and geos-posp/src/visu/pythonViewUtils/* to avoid dependency of geos-posp to geos-pv. Will be removed once all Paraview plugins will be moved to geos-pv.

@mlemayTTE mlemayTTE self-assigned this Apr 2, 2025
@mlemayTTE mlemayTTE linked an issue Apr 2, 2025 that may be closed by this pull request
@mlemayTTE mlemayTTE marked this pull request as ready for review April 3, 2025 15:11
Copy link
Contributor

@paloma-martinez paloma-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with the doc:

  • see github action, there are some warnings
  • automodule documentation : I tried to build the doc and had a lot of module import errors, can you check ?

@alexbenedicto alexbenedicto self-requested a review April 11, 2025 22:26
@alexbenedicto alexbenedicto self-requested a review April 15, 2025 17:25
@alexbenedicto alexbenedicto merged commit de62e29 into main Apr 15, 2025
39 checks passed
@alexbenedicto alexbenedicto deleted the lemay/feature/geospv_package branch April 15, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create geos-pv package and add PVGeosLogReader plugin
3 participants