refactor: Add a logger for all the vtk filter of geos-processing and all the plugin of geos-pv #178
Conversation
…ilterAndPlugins Update to the last version of the main
…ilterAndPlugins Update to the last version of the main
RomainBaville
added
type: cleanup
test-geos-integration
…ilterAndPlugins Update to the last version of the main
RomainBaville
added
flag: ready for review
and removed
test-geos-integration
RomainBaville
changed the base branch from
main
to
RomainBaville/refactor/RefactorFilterWithoutVTKPythonAlgorytmBase
RomainBaville
added
DO NOT MERGE!
test-geos-integration
jafranc
left a comment
jafranc
left a comment
There was a problem hiding this comment.
I think the try-except block there is some refactoring
|
|
||
|
|
||
| class RaiseMergeBlocks( TestCase ): | ||
| """Test failure on empty multiBlockDataSet.""" | ||
|
|
||
| def test_TypeError( self ) -> None: | ||
| """Test raise of TypeError.""" | ||
| multiBlockDataset = vtkMultiBlockDataSet() # should fail on empty data | ||
| if Version( vtk.__version__ ) < Version( "9.5" ): | ||
| with pytest.raises( VTKError ): | ||
| multiblockModifiers.mergeBlocks( multiBlockDataset, True ) |
There was a problem hiding this comment.
As I changed the filter MergeBlockEnhanced, its test needed to be change to, this test was usless with the new implementation of the filter so I move it to the test of the function mergeBlock
| f"The { self.piece } attributes { attributesAlreadyInMeshTo } are already present in the final mesh." ) | ||
| self.logger.error( f"The filter { self.logger.name } failed." ) | ||
| return False | ||
| try: |
There was a problem hiding this comment.
I am not sure of try except and raise in the try.
Raising here is fine but capturing should be done in the caller or caller's caller tbf
There was a problem hiding this comment.
In this pr I wanted to add or update the logger. To do that I used the same scheme try/except in all the plugins and filters. But your are right, the filtre may not use try/except. To keep "small" and "unitary" pr, I think it can be done in another pr (see pr #185 )
| self.logger.error( f"The new attribute { self.newAttributeName } has not been added." ) | ||
| self.logger.error( f"The filter { self.logger.name } failed." ) | ||
| return False | ||
| try: |
In the context of the code refactoring, this pr aims at creating a logger for all the vtk filters and all the ParaView plugins inplemented if absent.
This pr follows the pr #181.
This pr will not uniformize the output message of these logger. It will be done in a onther pr following the issue #184