Skip to content

Conversation

@tjb-ltk
Copy link
Contributor

@tjb-ltk tjb-ltk commented Sep 23, 2025

Reservoir volume constraint needs region average quantities for computing fluid properties. The ave quantities are computed via tasks such as CompositionalMultiphaseStatistics (and SinglePhaseStatistics equivalent) that are triggered in event section
Previously validation attempted to check if compute statistics wrappers were present on region. This was incorrect. but maybe the region should own the statistics object.

New check looks at if region ave quantities are zero.

integrated tests are forthcoming..

Copy link
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, to not expose the statistics component to the user, you can add in the well solver's registerDataOnMesh():

if( !wellControls.referenceReservoirRegion().empty() )
{
  // we need a statistics component for reference region pressure
  m_referenceRegionStats = taskManager.registerGroup<SinglePhaseStatistics>( "internalStats" )
    .setRestartFlags(NO_WRITE);
  m_referenceRegionStats.registerDataOnMeshRecursive(meshBodies);
}

m_referenceRegionStats would be a pointer or an std::optional, then you can call its execute() before reading it in updateVolRateForConstraint()

@MelReyCG
Copy link
Contributor

We are testing the current state of the branch

@MelReyCG
Copy link
Contributor

No success. I'll create a branch / PR on top of this one to contribute on this issue

@tjb-ltk tjb-ltk added type: bug Something isn't working ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Oct 20, 2025
@tjb-ltk tjb-ltk added the ci: run code coverage enables running of the code coverage CI jobs label Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 60.46512% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.36%. Comparing base (e68e1bc) to head (fdcd94e).

Files with missing lines Patch % Lines
...physicsSolvers/fluidFlow/wells/SinglePhaseWell.cpp 52.38% 10 Missing ⚠️
...rs/fluidFlow/wells/CompositionalMultiphaseWell.cpp 61.11% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3829   +/-   ##
========================================
  Coverage    59.36%   59.36%           
========================================
  Files         1337     1337           
  Lines       110815   110821    +6     
========================================
+ Hits         65788    65794    +6     
  Misses       45027    45027           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants