some fixes for apple clang compilation warnings/errors

[rrsettgast]

No description provided.

[rrsettgast]

@AntoineMazuyer I notice a lot of globalIndex to localIndex transformations are required the code that you committed. Is there a way to be more consistent about these types? For instance, globalIndices are pretty much never going to be used as the argument to an allocator call (i.e. resize) as the range of a long long is (18,446,744,073,709,551,615) and to large for a single node to handle.

[rrsettgast]

@herve-gross can you check if this works on your mac?

[herve-gross]

@rrsettgast I have just compiled GEOSX on this branch, all is fine. Woo!

[100%] Linking CXX executable ../../../tests/testXML [100%] Built target testXML

And here is the test:

Test project /Users/j0529096/Documents/code/GEOSX/build-default-release Start 1: blt_gtest_smoke 1/15 Test #1: blt_gtest_smoke .................. Passed 0.01 sec Start 2: blt_mpi_smoke 2/15 Test #2: blt_mpi_smoke .................... Passed 0.26 sec Start 3: testDataTypes 3/15 Test #3: testDataTypes .................... Passed 0.01 sec Start 4: testFloatingPointExceptions 4/15 Test #4: testFloatingPointExceptions ...... Passed 0.01 sec Start 5: testStackTrace 5/15 Test #5: testStackTrace ................... Passed 0.01 sec Start 6: testSidreBasic 6/15 Test #6: testSidreBasic ................... Passed 0.09 sec Start 7: testSidreExtended 7/15 Test #7: testSidreExtended ................ Passed 0.11 sec Start 8: testLAOperations 8/15 Test #8: testLAOperations ................. Passed 0.60 sec Start 9: testArray 9/15 Test #9: testArray ........................ Passed 0.09 sec Start 10: testObjectCatalog 10/15 Test #10: testObjectCatalog ................ Passed 0.01 sec Start 11: testSFINAE 11/15 Test #11: testSFINAE ....................... Passed 0.01 sec Start 12: testStringUtilities 12/15 Test #12: testStringUtilities .............. Passed 0.01 sec Start 13: testChaiVector 13/15 Test #13: testChaiVector ................... Passed 0.01 sec Start 14: testSortedArray 14/15 Test #14: testSortedArray .................. Passed 0.01 sec Start 15: testXML 15/15 Test #15: testXML .......................... Passed 0.14 sec 100% tests passed, 0 tests failed out of 15 Total Test time (real) = 1.43 sec

[herve-gross]

Compiles fine and all tests pass. Great!

[AntoineMazuyer]

@rrsettgast I will definitively check that. I thought localIndex was indexes of vertices within a cell (int8). My bad.

[rrsettgast]

@AntoineMazuyer a "localIndex" is a int32_fast, which is the fastest integer type with at least32 bytes. On the mac this is a 32 bit integer. On a linux system, it is a 64 bit integer. A "globalIndex" is a "long long" which is 64 bit on both. You can't go from a globalIndex to a localIndex reliable without possibly losing information when it is a 64bit->32bit conversion....like it is on a mac.