Skip to content

Improvements in mesh_doctor #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 69 commits into from
May 7, 2023
Merged

Improvements in mesh_doctor #2274

merged 69 commits into from
May 7, 2023

Conversation

TotoGaz
Copy link
Contributor

@TotoGaz TotoGaz commented Feb 3, 2023

This PR adds

  • A check/fix for wrong support nodes ordering.
  • Code that checks and fixes polyhedron with normals not directed inward. (Not exposed through the CLI though).
  • Checks if the mesh contains "non-conformal" elements (elements are one in front of the other with non matching nodes).
  • Checks that all elements are supported by geosx, including that polyhedra can be converted into supported elements.

The registration of checks has also been improved.

TotoGaz added 30 commits January 25, 2023 18:42
@TotoGaz
Add first version of the test for non conformal meshes.
f3c60ac 
Working on vtk polyhedron validations as well.
@TotoGaz
Small improvements.
606e521
@TotoGaz
First working version.
eddfae1
@TotoGaz
Validating that all the elements are supported.
68ffa47
@TotoGaz
Remove commented code.
696cc13
@TotoGaz
testing the face stream parsing.
c9db838
@TotoGaz
Adding a check to face stream parsing.
b07bab5
@TotoGaz
Commit a version that works with torn_wedges at least.
428f6f0
@TotoGaz
First version of the renumbering fix.
2346947
@TotoGaz
Copy the fields while reordering the support nodes.
b8da7da
@TotoGaz
A version that detects the non-conformal elements.
5a937e1
@TotoGaz
Better handling of the readers.
124430f
@TotoGaz
Registration now uses importlib.
39477ba
@TotoGaz
typos
89431d6
@TotoGaz
Changing the default threshold for self intersecting check.
32f44dd 
Adding warning and error messages.
@TotoGaz
Improving the renumbering fix.
db73cf3
@TotoGaz
First round of cleanings.
d00fd18
@TotoGaz
Tell about the verbose flag in the help
e3e4ab8
@TotoGaz
Optimization and cleanings.
21a3792
@TotoGaz
Moving function
4bd0382
@TotoGaz
Small cleanings.
e338e1a
@TotoGaz
Fix unit tests and orientation.
c204f7c
@TotoGaz
Improve tests, improve imports.
cd31528
@TotoGaz
Fixing some TODOs
6fc4ac3
@TotoGaz
Moving an iter fct to the utilities.
3b62ee3
@TotoGaz
Cleaning some TODOs, removing duplicated code.
562eac4
@TotoGaz
Better definition of some package and python dependencies.
6774525
@TotoGaz
Adding support for vtu file.
ecb959b 
Refactor vtk file mgmt.
@TotoGaz
Reduce indentation of the help msg.
ae874ab
@TotoGaz
Triangle distances
17302d8 
Extrusion optimisations
Supported elements
@TotoGaz TotoGaz linked an issue Apr 5, 2023 that may be closed by this pull request
Mismatch of cell volume computation in GEOSX and MeshDoctor #2253
Closed
@TotoGaz TotoGaz mentioned this pull request Apr 5, 2023
Closed
@TotoGaz TotoGaz added the EPIC - FF/Import Import of external faults and fractures label Apr 6, 2023
@TotoGaz TotoGaz merged commit 31ba5da into develop May 7, 2023
@TotoGaz TotoGaz deleted the feature/TotoGaz/nonConformalMeshesDetection branch May 7, 2023 04:07
@TotoGaz TotoGaz mentioned this pull request May 7, 2023
Open
15 tasks
@TotoGaz TotoGaz added the EPIC - Mesh/mesh_doctor Improving the `mesh_doctor` tool label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cssherman cssherman cssherman approved these changes

@francoishamon francoishamon francoishamon approved these changes

@castelletto1 castelletto1 Awaiting requested review from castelletto1

Assignees

@TotoGaz TotoGaz

Labels

EPIC - FF/Import Import of external faults and fractures EPIC - Mesh/mesh_doctor Improving the `mesh_doctor` tool type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mismatch of cell volume computation in GEOSX and MeshDoctor

3 participants

@TotoGaz @cssherman @francoishamon