-
Notifications
You must be signed in to change notification settings - Fork 97
[Feature] implement fault permeability models #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
arraySlice1d< real64 > const & permeability, | ||
arraySlice1d< real64 > const & dPerm_dDisplacement ) const | ||
{ | ||
real64 const shearDisp = std::max( abs(displacementJump[1]), abs(displacementJump[2]) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we do this with an L2-norm of the shear displacement instead of the max norm. shearMag = sqrt(u1^2+u2^2)
. We can then consistently linearize as dShearMag_dDisp = (1/shearMag)*{u1,u2}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, please check the update
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, but we should clarify the primary variables and linearization (dOuput_dInput).
Thanks for your suggestion. For simplicity, shear displacement dependent permeability is expressed as a function of the The dispJump has 3 components defined in the local coordinate system: However, in the Lagrange contact model, a similar vector is used for relative displacement in the local coordinate system but has a different name ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, changes look great to me. Let's have @CusiniM look quickly to make sure it is all consistent with his framework.
I prefer displacementJump
over localJump
as nomenclature. It clearly identifies the physical quantity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done!
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/DisplacementDependentPermeability.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Sy-Tuan Nguyen <[email protected]>
Conflicts: src/coreComponents/constitutive/CMakeLists.txt
…EOSX into feature/jhuang/faultPermeability
…EOSX into feature/jhuang/faultPermeability
This PR implements fault permeability models considering permeability change during fault slippage:
SlipPermeability_pEDFM_smoke
to the integratedTests and check the running on PecanGEOSX/integratedTests#178
Following two models will be implemented in separated PRs