-
Notifications
You must be signed in to change notification settings - Fork 97
Creation of a CoupleSolidModel to handle Poro-Solid-Damage models. #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TotoGaz
reviewed
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing really smart, just small C++ comments, nothing about architecture.
src/coreComponents/constitutive/permeability/permeabilitySelector.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/solid/porosity/PorosityBase.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/solid/porosity/PressurePorosity.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/solid/porosity/PressurePorosity.hpp
Outdated
Show resolved
Hide resolved
TotoGaz
reviewed
Jun 17, 2021
src/coreComponents/constitutive/permeability/CarmanKozenyPermeability.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/permeability/ParallelPlatesPermeability.hpp
Outdated
Show resolved
Hide resolved
…OSX into cusini/feature/porousSolidModel
…OSX into cusini/feature/porousSolidModel
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #1422
Rebaseline: https://github.com/GEOSX/integratedTests/pull/141
Integrated tests work on Lassen.
In my opinion the design works quite well. I have added the permeability models to this PR although they will only be used in #1311.
In a few words, I have created a base class template called
CoupledSolid
which owns method to accessThen, I have created 2 specialized classes:
PorousSolid
which always has aBiotPorosity
and is used solely for PoromechanicsCompressibleSolid
which can have various porosity models and, for now, assumes a nullModel for the solid Model so that all mechanics data (e.g. stresses) are not allocated. This model is what we would use for simulations without mechanics.For now, the damage can stay as it is ( I think) and the SOLID_TYPE can simply be a Damage etc...
Thus both the
PorousSolid
and theCompressibleSolid
would beI am registering a
PorousSolid
for each type ofSolidModel
so that the proper solid model gets instantiated based on the input, i.e.will automatically instantiate a
PorousSolid< ElasticIsotropic >
which will be aCoupledSolid<ElasticIsotropic, BiotPorosity, StrainDependentPermeability>
.The same thing could be done for the
CompressibleSolid
with various porosity and permeability models (I think special model could be used for very specific physics, e.g., chemical reactions that change the porosity).