Skip to content

Conversation

@evancofer
Copy link
Collaborator

Added preliminary support for regression models (using MatFileSampler) and user-specified evaluation metrics.

@kathyxchen
Copy link
Collaborator

Looks good so far! Just add an example of how to pass in metrics via config file (I think you already have this on your to-do list).
I'll update my config file document after we get your PR pushed to master.

@evancofer
Copy link
Collaborator Author

Which tutorial do you recommend adding it to?

@kathyxchen
Copy link
Collaborator

Probably in the getting started tutorial. You can pass in the default ROC AUC/AUPRC functions---it would just be there to show that the metrics parameter exists and how easy it would be to pass in some other metrics.

@evancofer evancofer removed the request for review from kathyxchen December 9, 2018 04:36
@evancofer evancofer changed the title [WIP] Preliminary support for regression models Preliminary support for regression models Dec 9, 2018
@evancofer
Copy link
Collaborator Author

@kathyxchen This is ready to be merged after you look through it.

@evancofer evancofer requested a review from kathyxchen December 9, 2018 16:24
Copy link
Collaborator

@kathyxchen kathyxchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the speedy PR, I'm super excited about having this functionality in Selene. :) The tutorial looks really good. After I update my branch for PR #57, I'll add links to your tutorial in "Getting started" & some other READMEs/docs pages.

@evancofer evancofer merged commit 7d53c70 into FunctionLab:master Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants