Fixed test 1325TestCase.php #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thirsch
commented
Jan 29, 2024
connorhu
approved these changes
Jan 29, 2024
alquerci
approved these changes
Jan 30, 2024
thePanz
reviewed
Jan 31, 2024
| ->fetchOne(array(), Doctrine_Core::HYDRATE_ARRAY); | ||
|
|
||
| $now = time(); | ||
| $time = strtotime($res['event_date']); |
Member
There was a problem hiding this comment.
Can't we align the two tests with the same check? In the "aliased" test, it is only checking that the eventDate column is set and greater than zero
Collaborator
Author
There was a problem hiding this comment.
Sure, sorry, I didn't go to the details, just have seen the unused variables and removed them. Pr is updated accordingly.
thirsch
force-pushed
the
bugfix/fix-test-1325
branch
from
2f7248c to
a5a3690
Compare
thePanz
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a small fix for the issue in pr #113