jms/serializer 2.0 compatibility #1899

goetas · 2018-06-14T15:19:31Z

This introduces the changes for supporting the upcoming jms/serializer 2.0 release

Some changes in composer.json and travisci are will not be necessary when serializer v1.13 will be released

goetas · 2018-07-25T15:15:30Z

Tests failure is not related to this PR but to #1912

GuilhemN · 2018-08-21T17:14:28Z

I don't truly know jms internals so I can hardly review this, please tell me when you think it is ready to merge :)

magnetik · 2018-09-17T10:04:46Z

I just faced it today so I'll hope it will get released :)

goetas · 2018-09-17T10:06:57Z

@magnetik

I just faced it today so I'll hope it will get released :)

Faced what? few days ago a first beta has been released (https://www.goetas.com/blog/whats-new-in-jmsserializer-v20/)

magnetik · 2018-09-17T10:08:31Z

The current incompatibility between FOSRestBundle and JMSSerializerBundle 3.0

goetas · 2018-09-17T15:35:06Z

@magnetik The status of this PR is almost definitive, I do not expect major changes.

If you want to try JMSSerializerBundle 3.0 with jms/serializer 2.0 (that is beta for now) you can use my fork.

Something as:

{
   "require": {
       "friendsofsymfony/rest-bundle": "dev-serializer-2.0-compat as 2.3.99",
       "jms/serializer": "^2.0@beta",
       "jms/metadata": "^2.0@beta"
    }
    "repositories": [
        {
            "type": "vcs",
            "url": "[email protected]:goetas/FOSRestBundle.git"
        }
    ]
}

goetas · 2018-09-17T15:35:43Z

@GuilhemN I think that this should be merged when jms will enter in the release-candidate stage (in 3 weeks)

GuilhemN · 2018-09-17T19:19:49Z

Ok, no problem, I'll merge it ☺

goetas · 2018-11-09T15:50:55Z

This is ready for review now!

goetas · 2018-11-09T20:02:05Z

Not sure if that custom fos type handler makes sense. It should have huge performance impact. Is there a reason for it?

GuilhemN · 2018-11-10T12:18:42Z

Not sure if that custom fos type handler makes sense. It should have huge performance impact. Is there a reason for it?

This is because of the Exception controller, we wanted users to be able to overide exceptions rendering for each sub class. I didn't find a better and simpler alternative at the time at least.

goetas · 2018-11-13T17:12:21Z

@GuilhemN I think the best approach is to keep this as it is and optimize the handler in a different PR.
IMO this is ready for rewiew or merge if it looks OK to you

Serializer/JMSHandlerRegistryV2.php

composer.json

goetas · 2018-11-15T09:34:18Z

Serializer/JMSHandlerRegistryV2.php

+            if (null !== $handler) {
+                return $handler;
+            }
+        } while ($typeName = get_parent_class($typeName));


As this was used for the exception handler, will it make sense to limit this behavior only for classes extending Exception ?

Performance of this loop are really impacting serialization performance...

Sure we could do that indeed

notrix · 2018-11-15T11:37:40Z

👍

Saracevas · 2018-11-22T16:57:16Z

Excellent work everyone, do we know when this will be merged in?

GuilhemN · 2018-11-25T08:09:07Z

Thank you @goetas :)

goetas · 2018-11-25T08:26:39Z

yay!

mansartesteban · 2018-11-28T21:40:00Z

Hey guys !
Sorry but i don't understand i'm new to github community and the system of issues is new to me (and awesome by the way).
If i understand weel, you fixed this issue in commit 35ccb78 and pushed it to the master branch isn't it ?
So if the fix is on master and if i "composer friendsofsymfony/rest-bundle && composer update jms/serializer-bundle" it should be working no ?
I still have the same problem and the files JMSHandlerRegistry at me is the same than v2.3 ... and my composer info say that I have the v2.4.
I don't understand could someone help me plz :D !

notrix · 2018-11-29T06:56:35Z

@mansartesteban make sure you have "friendsofsymfony/rest-bundle": "dev-master" in your composer.json if you want changes from master branch. Or you can wait till stable version release.

mansartesteban · 2018-11-29T10:37:57Z

Oh ! It works ! Thank you very much <3

This PR was merged into the 2.3-dev branch. Discussion ---------- Drop jms/serializer <1.13 ~~`GraphNavigatorInterface` has been introduced in JMS Serializer v1.12.0. We should use `GraphNavigator` instead to maintain backward compatibility with v1.11.0 and lower.~~ #1899 breaks compatibility with `jms/serializer <1.13.0` by using: - `JMS\Serializer\GraphNavigatorInterface` (>=1.12) - `JMS\Serializer\Context::hasAttribute()` (>=1.13) - `JMS\Serializer\Context::getAttribute()` (>=1.13) However, it is still possible to install older version of `jms/serializer` together with FOSRestBundle. This PR fixes it by updating a `conflict` constraint. Commits ------- 535e366 drop jms/serializer <1.13.0

magnetik · 2018-12-04T10:23:04Z

Can a release be tagged with this fix?

Thanks.

goetas force-pushed the serializer-2.0-compat branch 2 times, most recently from bf5ea97 to dcf3fd8 Compare June 14, 2018 15:46

goetas force-pushed the serializer-2.0-compat branch 3 times, most recently from 751ac96 to 397080a Compare July 25, 2018 15:15

goetas force-pushed the serializer-2.0-compat branch from 397080a to 3429bc5 Compare July 25, 2018 15:17

goetas added 4 commits November 9, 2018 15:53

context adapter

c0ca48e

update subscribing handlers

bb9f9db

add JMSHandlerRegistry compatible with jms serializer 2.0

6d342f9

update serializer tests

51fce5a

goetas force-pushed the serializer-2.0-compat branch 2 times, most recently from ed74e10 to 2b3d35d Compare November 9, 2018 15:40

goetas changed the title ~~[WIP] jms/serializer 2.0 compatibility~~ jms/serializer 2.0 compatibility Nov 9, 2018

goetas added 2 commits November 9, 2018 16:48

update jms serializer deps allowing jms serializer 2.0

96b7f29

style changes

8201895

goetas force-pushed the serializer-2.0-compat branch from 2b3d35d to 8201895 Compare November 9, 2018 15:48

xabbuh mentioned this pull request Nov 10, 2018

JMSHandlerRegistry must implements HandlerRegistryInterface correctly #1955

Closed

xabbuh reviewed Nov 15, 2018

View reviewed changes

Serializer/JMSHandlerRegistryV2.php Outdated Show resolved Hide resolved

composer.json Show resolved Hide resolved

goetas commented Nov 15, 2018

View reviewed changes

goetas added 2 commits November 15, 2018 10:45

add conflict rule for jms bundle v1

d18cbc6

mark the new handler as final

f3f74df

GuilhemN merged commit 35ccb78 into FriendsOfSymfony:master Nov 25, 2018

goetas deleted the serializer-2.0-compat branch November 25, 2018 08:26

IonBazan mentioned this pull request Nov 29, 2018

Drop jms/serializer <1.13 #1962

Merged

GuilhemN mentioned this pull request Jan 2, 2019

JMSSerializerAdapter is accessing private property of JMS\Serializer\Context #1975

Closed

goetas mentioned this pull request Feb 6, 2019

How serialize Exception class? schmittjoh/serializer#1038

Closed

GuilhemN mentioned this pull request May 30, 2020

Deprecate the behavior of the JMSHandlerRegistry to improve performance in v3 #2227

Closed

jms/serializer 2.0 compatibility #1899

jms/serializer 2.0 compatibility #1899

Uh oh!

Conversation

goetas commented Jun 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

goetas commented Jul 25, 2018

Uh oh!

GuilhemN commented Aug 21, 2018

Uh oh!

magnetik commented Sep 17, 2018

Uh oh!

goetas commented Sep 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magnetik commented Sep 17, 2018

Uh oh!

goetas commented Sep 17, 2018

Uh oh!

goetas commented Sep 17, 2018

Uh oh!

GuilhemN commented Sep 17, 2018

Uh oh!

goetas commented Nov 9, 2018

Uh oh!

goetas commented Nov 9, 2018

Uh oh!

GuilhemN commented Nov 10, 2018

Uh oh!

goetas commented Nov 13, 2018

Uh oh!

Uh oh!

Uh oh!

goetas Nov 15, 2018

Choose a reason for hiding this comment

Uh oh!

GuilhemN Nov 25, 2018

Choose a reason for hiding this comment

Uh oh!

notrix commented Nov 15, 2018

Uh oh!

Saracevas commented Nov 22, 2018

Uh oh!

GuilhemN commented Nov 25, 2018

Uh oh!

goetas commented Nov 25, 2018

Uh oh!

mansartesteban commented Nov 28, 2018

Uh oh!

notrix commented Nov 29, 2018

Uh oh!

mansartesteban commented Nov 29, 2018

Uh oh!

magnetik commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

goetas commented Jun 14, 2018 •

edited

Loading

goetas commented Sep 17, 2018 •

edited

Loading

magnetik commented Dec 4, 2018 •

edited

Loading